[Differential] [Accepted] D2759: [kdevplatform] UI fix: add "Analyzers" category for appropriate plugins

kfunk (Kevin Funk) noreply at phabricator.kde.org
Tue Sep 13 12:09:12 UTC 2016


kfunk accepted this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision is now accepted and ready to land.


  Rest LGTM

INLINE COMMENTS

> uicontroller.cpp:531
> +    cfgDlg.addConfigPage(analyzersPreferences, configPages[5]);
> +    cfgDlg.addSubConfigPage(analyzersPreferences, new BGPreferences(parent));
> +

I don't think we should move the background parser settings page to the Analyzers category. Thinking about it, it probably makes more sense to move it to the Language Support category.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2759

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160913/e6f0dc6f/attachment.html>


More information about the KDevelop-devel mailing list