Review Request 128880: [OS X] use a different tab bar widget for tabbed documents

René J.V. Bertin rjvbertin at
Sat Sep 10 17:41:12 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 10, 2016, 7:41 p.m.)

Review request for KDE Software on Mac OS X and KDevelop.


Made the description a bit more accurate re: when the `ContainerTabBar` ctor is called.

Repository: kdevplatform

Description (updated)

This is a potential fix for an issue raised on BKO:

It's also the most complete/implementation:
- applies only when the Macintosh widget style is being used
- if so, creates a QStyle object for the Fusion widget style
- when successful, sets the `Sublime::ContainerTabBar` to use that style

This solves all issues stemming from Qt's use of a "native" widget that is intended only for use in dialogs and not in tabbed document interfaces.

In my testing, the `ContainerTabBar` ctor is called only rarely, apparently only when changing views (e.g. code -> patch review and back again, or code -> debug). If that observation is correct, use of a global `qTabBarStyle` variable is justified (but more elegant solutions might exist). This observation also justifies (IMHO) the check for the active application style rather than using an `#ifdef Q_OS_OSX` or even applying the fix across all platforms and application styles. That is certainly a possibility that doesn't lead to any shocking style mismatches in my eyes. It does cause some loss of compactness when using my QtCurve settings, which is why I added the style check; a small cost as a gesture to users of a highly configurable style.

There is still some weirdness behind the tabs which looks like a misaligned well or frame. I'd love to get that right too.


  sublime/container.cpp b04f6c3 



See (unpatched) and the last series of screenshots attached to the ticket on BKO. They show the fix applied to various styles on OS X.


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list