Review Request 128862: mouseover highlight: use search background color
Kevin Funk
kfunk at kde.org
Thu Sep 8 20:50:30 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128862/#review99002
-----------------------------------------------------------
Ship it!
LGTM.
Please close the related bug: https://bugs.kde.org/show_bug.cgi?id=368458
PS: Just tested; unfortunately we need a restart to apply these colors (due to the `static Attribute::Ptr standardAttribute`). Should be fixed in a follow-up commit.
- Kevin Funk
On Sept. 8, 2016, 8:10 p.m., Sven Brauch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128862/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2016, 8:10 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> It was hardcoded to bright yellow and people were complaining about it since basically ever.
>
>
> Diffs
> -----
>
> plugins/contextbrowser/contextbrowser.cpp 0f7dc26
>
> Diff: https://git.reviewboard.kde.org/r/128862/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sven Brauch
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160908/65121f4a/attachment.html>
More information about the KDevelop-devel
mailing list