[Differential] [Accepted] D2634: [kdevplatform] Add ability to show ProblemsView with selected model data.

[kfunk (Kevin Funk)]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  LGTM besides the one remaining issue.

INLINE COMMENTS

> problemmodelset.cpp:80
> +{
> +    for (const ModelData &data : d->data) {
> +        if (data.name == name) {

Use foreach (otherwise you're detaching the vector)

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2634

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, mwolff, #kdevelop, kfunk
Cc: kfunk, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160908/07d6ed2e/attachment.html>