Review Request 128762: qmljs: restructure duchain locking to prevent deadlocks

Sven Brauch mail at
Mon Sep 5 21:44:16 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 5, 2016, 9:44 p.m.)

Review request for KDevelop and Kevin Funk.

Bugs: 367825

Repository: kdevelop


We _must not_ hold a duchain lock when contextOfFile() is called. That
might try to add something to the background parser queue, which locks
the background parser mutex; then both locks are held, which causes

Diffs (updated)

  languages/qmljs/codecompletion/context.cpp 3a44f45 
  languages/qmljs/codecompletion/tests/test_qmljscompletion.cpp b689418 
  languages/qmljs/duchain/declarationbuilder.cpp fb0cb5d 
  languages/qmljs/duchain/expressionvisitor.cpp 3b641f5 
  languages/qmljs/duchain/helper.cpp e537103 



Opened some test project, no crashes, no freezes, and the (I think) reason for the freeze is gone.


Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list