Review Request 128830: [2/2] clang parse job: do initialization in run(), not in the constructor

[Sven Brauch]

> On Sept. 5, 2016, 6:33 p.m., David Nolden wrote:
> > Are you sure this is necessary?
> > 
> > At least the way I implemented it originally, this functionality would already be covered by the normal check.
> 
> Sven Brauch wrote:
>     No, not sure actually. But I read the code and I didn't find where this case would be covered.
> 
> David Nolden wrote:
>     Since the foreground thread locks the foreground lock by default, this shouldn't be necessary.

Ok, thank you for the hint. I'm discarding this.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128830/#review98888
-----------------------------------------------------------


On Sept. 5, 2016, 7:28 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128830/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2016, 7:28 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> change VERIFY_FOREGROUND_LOCKED macro to also allow us being the GUI thread
> 
> 
> Diffs
> -----
> 
>   util/foregroundlock.h 6150ad7 
> 
> Diff: https://git.reviewboard.kde.org/r/128830/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160905/03a8a0c0/attachment.html>