[Differential] [Requested Changes To] D2651: Path: add ancestor method

[mwolff (Milian Wolff)]

mwolff requested changes to this revision.
mwolff added a reviewer: mwolff.
mwolff added a comment.
This revision now requires changes to proceed.


  good overall, but please add some unit test coverage (see test_path.{cpp,h}).

INLINE COMMENTS

> path.cpp:443
>      Path ret(*this);
> -    if (m_data.size() == (1 + (isRemote() ? 1 : 0))) {
> +    unsigned remoteLen = isRemote() ? 1 : 0;
> +

const

> path.h:334
> +     */
> +    Path ancestor(unsigned steps) const;
> +

Qt style: use uint

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2651

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: nicolaih, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160905/76fb68d5/attachment.html>