Review Request 129224: WIP: Allow using QTextBrowser for documentation

[René J.V. Bertin]

> On Oct. 20, 2016, 12:35 a.m., Aleix Pol Gonzalez wrote:
> > What do you mean you need to port the NAM? Does navigating work?
> > Also would it make sense to use QtWebEngine instead of QTextBrowser? It's not fun to use a frontend that might just misrepresent what we need to show. I'm not very happy about keeping QtWebKit, so I'd look into finding an acceptable replacement.
> 
> Sven Brauch wrote:
>     If we can get rid of depending on a full-featured web browser, be it QtWebEngine or QtWebKit, we should do that. I bet it will be the exact same story all over again with QtWebEngine in five years.
> 
> Alex Richardson wrote:
>     I tried use QtWebEngine and I still have some code lying around. However, it kept crashing for me somewhere deep inside webengine.
>     https://paste.kde.org/poyutya7e

David Faure is reanimating Konqueror and has ported it to QtWebEngine. According to him you really want to be using QWE 5.8 to get some form of stability.

IMHO that's fine (kind of) for a web browser that's very much a work in progress, but I am fully with Sven. KDevelop shouldn't have to depend on a full-featured web browser. It could be considered to provide support for "fancy html" that requires more advanced browser functionality via a plugin, which might even use Konqueror's `qwebenginepart` when that one is more or less stabilised. But I'd much prefer a context menu option to open a documentation link in the Chromium-based webbrowser I already have running rather than firing up another RAM-hungry copy. After all it's not like KDevelop and concurrent builds aren't (RAM hungry).

I am biased of course, as I avoid KDevelop's documentation thingy as much as possible because it is rarely accepts to remain closed when I told it to.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129224/#review100152
-----------------------------------------------------------


On Oct. 19, 2016, 5:56 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129224/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2016, 5:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> If the system doesn't have QtWebKit use QTextBrowser instead
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e7a45a9284f5725d77eea281739a38fc1ebfc51d 
>   documentation/manpage/manpagedocumentation.cpp f3584b91865eae7a75e58939f1b766119bc47373 
>   documentation/qthelp/qthelpdocumentation.h 97f27aa72d33cf0799d3ee0eca7044ad807caad4 
>   documentation/qthelp/qthelpdocumentation.cpp e090bc984e2a539f9299473916b47450aec79d4b 
> 
> Diff: https://git.reviewboard.kde.org/r/129224/diff/
> 
> 
> Testing
> -------
> 
> Man pages work, QtHelp kinda works. Still need to port the custom NetworkAccessManager to QTextBrowser.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161029/34a72d55/attachment.html>