[Differential] [Request, 160 lines] D3189: ProblemModelSet: use ids instead names for problems find, remove, show

antonanikin (Anton Anikin) noreply at phabricator.kde.org
Fri Oct 28 12:48:26 UTC 2016


antonanikin created this revision.
antonanikin added a reviewer: KDevelop.
antonanikin added a subscriber: kdevelop-devel.

REVISION SUMMARY
  This patch adds id field to ModelData and uses it for problems manage. This is more correct way which allows us to use translated problem model names and don't think about translation troubles during common operations.

TEST PLAN
  Tested on master branch. Also tested with some plugins (needs code update): kdev-clangtidy, kdev-cppcheck, kdev-valgrind, kdev-verapp

REPOSITORY
  rKDEVPLATFORM KDevPlatform

BRANCH
  problem_model_set_id

REVISION DETAIL
  https://phabricator.kde.org/D3189

AFFECTED FILES
  plugins/problemreporter/problemreporterplugin.cpp
  plugins/problemreporter/problemreporterplugin.h
  plugins/problemreporter/problemsview.cpp
  plugins/problemreporter/problemsview.h
  plugins/problemreporter/tests/test_problemsview.cpp
  shell/problemmodelset.cpp
  shell/problemmodelset.h
  shell/tests/test_problemmodelset.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161028/e8e82903/attachment.html>


More information about the KDevelop-devel mailing list