[Differential] [Commented On] D3164: Fix Problem Highlighter - use problems from all Problem Models

[antonanikin (Anton Anikin)]

antonanikin added inline comments.

INLINE COMMENTS

> kfunk wrote in problemreporterplugin.cpp:219
> Hm, why do update the problems for all open documents now? This could get slow with lots of documents open at a time, no?

This is necessary due re-highlighting is not performed automatically for opened documents. If we switch to other opened document it will have "old highlights" which is wrong. Currently re-highlighting runs only for new opened documents. My previous version do it (with using other signals connected) for such case but it's wrong to run re-highlighting every time for non-changed problems.

We can add some mechanism to save re-highlighting "queries" to some structure (like vector) and run needed on document switch. I can do it in next revision if necessary.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3164

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161027/e98ac534/attachment.html>