[Differential] [Requested Changes To] D3110: Periodically update progress bar

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> backgroundparser.cpp:210
> +
> +        m_progressTimer.start();
>      }

There must be a different way to implement this feature, a constantly running timer is not good style. Maybe start/resume based on whether there are active jobs running?

In that regard, you should also be able to eliminate the need for `m_needEmitProgress`.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3110

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: wcpan, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161027/d1e2c41d/attachment.html>