[Differential] [Accepted] D3170: Centralize code that deals with ideal tool view actions in one class

[kfunk (Kevin Funk)]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  LGTM, way better than the asterisk.

INLINE COMMENTS

> framestackwidget.cpp:257
>      bool enable = state == IDebugSession::PausedState || state == IDebugSession::StoppedState;
> -    m_framesTreeView->setEnabled(enable);
> -    m_threadsListView->setEnabled(enable);
> +    setEnabled(enable);
>  }

The initial state of that tool view is wrong; maybe needs a `setEnabled(false)` in the ctor?

REPOSITORY
  rKDEVPLATFORM KDevPlatform

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3170

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, brauch, #kdevelop, kfunk
Cc: kfunk, antonanikin, brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161027/1a313307/attachment.html>