[Differential] [Commented On] D3164: Fix Problem Highlighter - use problems from all Problem Models

[kfunk (Kevin Funk)]

kfunk added inline comments.

INLINE COMMENTS

> problemstore.cpp:48
> +    /// All stored problems
> +    QVector<KDevelop::IProblem::Ptr> m_problems;
>  };

Maybe indeed call it `m_allProblems`, or even `m_accumulatedProblems`

> problemstore.cpp:80
> +    // set signals block to prevent wrong emitting of problemsChanged()
> +    int oldSize = d->m_problems.size();
> +    bool oldState = blockSignals(true);

Use `QSignalBlocker`

> problemstore.cpp:129
> +        emit problemsChanged();
> +    d->m_problems.clear();
>  }

Move this line into the if-block?

> problemstore.h:129
>  signals:
> -    /// Emitted when the problems change
> +    /// Emitted when the any store setting (grouping, scope, severity, document) is changed
>      void changed();

Typo, better: "when any store setting ..."?

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3164

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161026/310980d9/attachment.html>