[Differential] [Requested Changes To] D3068: Towards KConfigSkeleton

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> plugin.cpp:74
> +    m_actionCheckFile = new QAction("clang-tidy", this);
> +    m_actionCheckFile->setStatusTip(i18n("Launches ClangTidy for current file"));
> +    m_actionCheckFile->setText(i18n("Clang-tidy (Current file)"));

"Clang-Tidy"

> plugin.cpp:75
> +    m_actionCheckFile->setStatusTip(i18n("Launches ClangTidy for current file"));
> +    m_actionCheckFile->setText(i18n("Clang-tidy (Current file)"));
> +    connect(m_actionCheckFile, &QAction::triggered, this, &Plugin::runClangTidyFile);

Dito

> plugin.cpp:78
> +    //     connect(m_actionCheckFile,SIGNAL(triggered(bool)), this, SLOT(runClangTidyFile(void)));
> +    actionCollection()->addAction("clangTidy_file", m_actionCheckFile);
>  

Dito

> nihon_plugin.cpp:200
> +    qCDebug(KDEV_CLANGTIDY) << "setting clangTidy rc file";
> +    setXMLFile("kdevclangTidy.rc");
>  

This should stay as is. All lowercase.

> nihon_plugin.cpp:203
>      QAction* act_checkfile;
> -    act_checkfile = actionCollection()->addAction("clangtidy_file", this, SLOT(runClangtidyFile()));
> -    act_checkfile->setStatusTip(i18n("Launches Clangtidy for current file"));
> +    act_checkfile = actionCollection()->addAction("clangTidy_file", this, SLOT(runClangTidyFile()));
> +    act_checkfile->setStatusTip(i18n("Launches ClangTidy for current file"));

Dito

> plugin.cpp:56
>  
>  using namespace KDevelop;

Btw: I find it confusing to have the implementation of the plugin as test sources again. Can we find something else, something artificially constructed?

> plugin.cpp:70
>      QAction* act_checkfile;
> -    act_checkfile = actionCollection()->addAction("clangtidy_file", this, SLOT(runClangtidyFile()));
> -    act_checkfile->setStatusTip(i18n("Launches Clangtidy for current file"));
> +    act_checkfile = actionCollection()->addAction("clangTidy_file", this, SLOT(runClangTidyFile()));
> +    act_checkfile->setStatusTip(i18n("Launches ClangTidy for current file"));

Dito

> plugin.cpp:71
> +    act_checkfile = actionCollection()->addAction("clangTidy_file", this, SLOT(runClangTidyFile()));
> +    act_checkfile->setStatusTip(i18n("Launches ClangTidy for current file"));
>      act_checkfile->setText(i18n("clang-tidy"));

"Clang-Tidy" in user-visible strings

> plugin.cpp:76
>      //     QAction* act_check_all_files;
> -    //     act_check_all_files = actionCollection()->addAction ( "clangtidy_all", this, SLOT ( runClangtidyAll() ) );
> -    //     act_check_all_files->setStatusTip ( i18n ( "Launches clangtidy for all translation "
> +    //     act_check_all_files = actionCollection()->addAction ( "clangTidy_all", this, SLOT ( runClangTidyAll() ) );
> +    //     act_check_all_files->setStatusTip ( i18n ( "Launches clangTidy for all translation "

Dito

REPOSITORY
  R218 KDev Clang-Tidy Support

REVISION DETAIL
  https://phabricator.kde.org/D3068

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: coliveira, antonanikin, kfunk
Cc: kdevelop-devel, #kdevelop
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161021/2f15186d/attachment-0001.html>