[Differential] [Accepted] D3108: Add filtering for ProblemsView

[kfunk (Kevin Funk)]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Rest LGTM, thanks!
  
  To master branch.

INLINE COMMENTS

> problemsview.cpp:211
> +
> +        connect(filterTimer, &QTimer::timeout, [this]() {
> +            setFilter(m_filterEdit->text());

Use the 4-arg version of connect, use `this` as receiver.

Makes sure the connection gets destroyed if the receiver is destructed.

> problemsview.cpp:223
> +
> +        connect(m_filterEdit, &QLineEdit::textChanged, [this, filterTimer](const QString&) {
> +            filterTimer->start(500);

Dito

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3108

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: obogdan, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161020/7e0316de/attachment.html>