Review Request 129224: WIP: Allow using QTextBrowser for documentation

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129224/#review100152
-----------------------------------------------------------



What do you mean you need to port the NAM? Does navigating work?
Also would it make sense to use QtWebEngine instead of QTextBrowser? It's not fun to use a frontend that might just misrepresent what we need to show. I'm not very happy about keeping QtWebKit, so I'd look into finding an acceptable replacement.

- Aleix Pol Gonzalez


On Oct. 19, 2016, 5:56 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129224/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2016, 5:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> If the system doesn't have QtWebKit use QTextBrowser instead
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e7a45a9284f5725d77eea281739a38fc1ebfc51d 
>   documentation/manpage/manpagedocumentation.cpp f3584b91865eae7a75e58939f1b766119bc47373 
>   documentation/qthelp/qthelpdocumentation.h 97f27aa72d33cf0799d3ee0eca7044ad807caad4 
>   documentation/qthelp/qthelpdocumentation.cpp e090bc984e2a539f9299473916b47450aec79d4b 
> 
> Diff: https://git.reviewboard.kde.org/r/129224/diff/
> 
> 
> Testing
> -------
> 
> Man pages work, QtHelp kinda works. Still need to port the custom NetworkAccessManager to QTextBrowser.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161019/728d1dff/attachment.html>