Review Request 126156: WIP: Allow using QTextBrowser for documentation instead of QtWebKit

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126156/#review100142
-----------------------------------------------------------



Generally: +1


CMakeLists.txt (line 45)
<https://git.reviewboard.kde.org/r/126156/#comment67261>

    Unrelated hunk?



documentation/CMakeLists.txt (line 4)
<https://git.reviewboard.kde.org/r/126156/#comment67262>

    `s/OPTIONAL/RECOMMENDED/`? I consider QTextBrowser to be a fallback (as it's not fully working yet).



documentation/config-documentation.h.cmake (line 5)
<https://git.reviewboard.kde.org/r/126156/#comment67263>

    Please just expose `HAVE_QTWEBKIT` here.
    
    Do all the other stuff in the .h/.cpp files. Way easier to understand IMO.
    
    You also already *use* HAVE_QTWEBKIT in the other files.


- Kevin Funk


On Oct. 19, 2016, 3:53 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126156/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2016, 3:53 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Allow using QTextBrowser instead of QtWebKit
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1aab677513ba2af9549ab426c4e2adb33a4d71a2 
>   KDevPlatformConfig.cmake.in 73664ebd910c4c7e3acc41bdc048b0dc6141777e 
>   documentation/CMakeLists.txt ff57e258ab5c62ce737c4013005247d585e87b61 
>   documentation/config-documentation.h.cmake PRE-CREATION 
>   documentation/standarddocumentationview.h 3f429752032be6fa2b0b49fb3094f7bf31a28367 
>   documentation/standarddocumentationview.cpp 3cb98886e0e9b3fda33caeecbfdc2e20ebb952b8 
> 
> Diff: https://git.reviewboard.kde.org/r/126156/diff/
> 
> 
> Testing
> -------
> 
> compiles on my system which no longer has QtWebKit
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161019/e1631a3c/attachment-0001.html>