[Differential] [Commented On] D2925: Port kdev_format_source script to C++/Qt

[kfunk (Kevin Funk)]

kfunk added inline comments.

INLINE COMMENTS

> test_kdevformatsource.cpp:32
> +{
> +    QCOMPARE(init(), true);
> +

Hmm, test looks useful, but it would be more easy to understand if you'd have used data-driven tests here. In the data section, you could both specify the format file contents + expected contents for the source files.

Right know we're duplicating a lot of code in the test functions.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2925

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161018/2865f31b/attachment.html>