[Differential] [Commented On] D3087: Final step for use-nullptr

[antonanikin (Anton Anikin)]

antonanikin added a comment.


  > I don't like adding boiler plate code in kdevplatform just to fix issues in external libs.
  
  +1, it's ugly
  
  > `-Wzero-as-null-pointer-constant` should not warn for "system" headers... Is that a GCC bug?
  
  I don't know. But with gcc-6.2.1 this flag produce warnings/errors for such cases (includes).
  
  As a result I suggest drop "-Wno-error=zero-as-null-pointer-constant" from patch and clean it from redundant lines.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3087

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161017/bc9ce1f1/attachment.html>