[Differential] [Accepted] D3073: Feature "Diff From Branch" on BranchManager

[brauch (Sven Brauch)]

brauch accepted this revision.
brauch added a comment.


  Apart from the text on the button, looks good to me!

INLINE COMMENTS

> coliveira wrote in branchmanager.ui:55
> This is harder than writing the code. 
> I don't like the option "Diff between branches" because it seems that we have to choose two branches in the list view to compare, which is not possible right now, and I don't want to change it. None of the options I can think fits on one line to keep the buttons as narrow as they currently are.
> 
> Other options: "Changes relative to", "Compare to Branch".
> I like they way the last one appears on the screen.
> What do you think?
> 
> F366793: pasted_file <https://phabricator.kde.org/F366793>
> F366795: pasted_file <https://phabricator.kde.org/F366795>

I don't like "compare to branch", it's imo unclear what that means. The word "diff" or "differences" makes it clear you'll get a diff, "compare to" could be anything.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3073

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: coliveira, apol, kfunk, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161017/bf10b8b7/attachment-0001.html>