[Differential] [Requested Changes To] D3087: Final step for use-nullptr

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision now requires changes to proceed.


  Some look like they shouldn't be needed. Could you explain why they are...?

INLINE COMMENTS

> test_sessioncontroller.cpp:97
>  {
> -    QTest::addColumn<QString>( "sessionName" );
> +    QTest::addColumn<QString>( "sessionName", nullptr );
>      QTest::newRow("SimpleName") << "TestSession";

Dito: Why are these needed?

> test_areaoperation.cpp:198
>      //====== check for m_area1 ======
> -    MainWindow mw1(m_controller);
> +    MainWindow mw1(m_controller, nullptr);
>      m_controller->showArea(m_area1, &mw1);

Uh oh, why are these needed?

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3087

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161017/1c4aaf30/attachment-0001.html>