[Differential] [Accepted] D2929: Class Browser list expanding during search
kfunk (Kevin Funk)
noreply at phabricator.kde.org
Wed Oct 12 19:38:01 UTC 2016
kfunk accepted this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision is now accepted and ready to land.
Works fine for me. It's still reasonably fast, even with qtbase.git loaded in KDevelop.
One thing to consider: We shouldn't update the filter each time the text is changed (bad performance for big projects). We should delay updating the filter a bit.
Here's some info how to do it: https://wiki.qt.io/Delay_action_to_wait_for_user_interaction
Some more remarks:
- To 5.0 branch please
- Please separate style cleanups from the actual behavior change
- Please be more verbose in the commit message, explain before/after situation
REPOSITORY
rKDEVPLATFORM KDevPlatform
REVISION DETAIL
https://phabricator.kde.org/D2929
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161012/06163ed5/attachment.html>
More information about the KDevelop-devel
mailing list