[Differential] [Commented On] D2902: Fix Bug 285162: adjust documentation view font settings by values taken from system settings (DE)

Tue Oct 11 02:24:10 UTC 2016

antonanikin added a comment.

  > I didn't so exactly follow this, but I'm confused why the "+4" is necessary. This sounds like something which would break on other systems. Don't we get the correct font size from e.g. the KDE default font?

  "Magic constant" is removed. Now we use `pixelSize` of system fonts. It works good on my system (linux) but resulting font size is slightly bigger than system font. It can be "fixed" with `pixelSize() - 1`, but I think it not necessary (and this again adds "magic constatnt"), slightly bigger new documentation fonts are better then current too small sizes.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2902

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop
Cc: brauch, cordlandwehr, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161011/3b1b095c/attachment-0001.html>