[Differential] [Updated, 916 lines] D2840: First diff for kdev-clang-tidy

[coliveira (Carlos Nihelton)]

coliveira removed a reviewer: mwolff.
coliveira changed the visibility from "All Users" to "Public (No Login Required)".
coliveira updated this revision to Diff 7239.
coliveira marked 4 inline comments as done.
coliveira added a comment.


  Improved style by preferring camel case identifiers, cleaned wrong comments, changed ClangFormat target to issue a WARNING instead of ERROR in case of clang-format executable not being found, and changed the API on PerProjectConfigPage to issue a signal when the selection of checks change instead of using a QStringList pointer owned by someone else.
  
  I didn't get a clue on how to use KConfigSkeleton in PerProjectConfigPage because the list of checks is generated during runtime, by running clang-tidy and parsing its output.  I had a hard time trying to use this and still have the list of checks not hard-coded inside the plugin code, which I believe it's the right way to do the plugin, since the list of checks may change from one version to another of clang-tidy. Ideas are welcome.

REPOSITORY
  R218 KDev Clang-Tidy Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2840?vs=6885&id=7239

REVISION DETAIL
  https://phabricator.kde.org/D2840

AFFECTED FILES
  .clang-tidy
  .gitignore
  CMakeLists.txt
  cmake/ClangFormatAll.cmake
  src/config/clangtidypreferences.cpp
  src/config/clangtidypreferences.h
  src/config/configgroup.cpp
  src/config/configgroup.h
  src/config/configgroup.h.in
  src/config/perprojectconfigpage.cpp
  src/config/perprojectconfigpage.h
  src/config/ui/clangtidysettings.ui
  src/config/ui/perprojectconfig.ui
  src/parsers/clangtidyparser.cpp
  src/parsers/clangtidyparser.h
  src/parsers/replacementparser.cpp
  src/parsers/replacementparser.h
  src/plugin/job.cpp
  src/plugin/job.h
  src/plugin/plugin.cpp
  src/plugin/plugin.h
  src/plugin/plugin.h.in
  src/qCDebug/debug.cpp
  tests/CMakeLists.txt
  tests/data/nihon_plugin.cpp
  tests/data/plugin.cpp
  tests/test_clangtidyjob.cpp
  tests/test_clangtidyjob.h
  tests/test_clangtidyparser.cpp
  tests/test_clangtidyparser.h
  tests/test_plugin.cpp
  tests/test_plugin.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: coliveira, apol, antonanikin, kfunk
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161010/103d96fc/attachment.html>