Review Request 129108: decltype support test

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129108/#review99806
-----------------------------------------------------------



Any context why you were writing this test function to begin with?


languages/clang/tests/test_duchain.cpp (line 565)
<https://git.reviewboard.kde.org/r/129108/#comment67079>

    This calls for turning this test function into a data-driven test. Refer to http://doc.qt.io/qt-5/qttestlib-tutorial2-example.html.
    
    Please split up the test function into a data function + test function.


- Kevin Funk


On Oct. 5, 2016, 10:12 p.m., Radu Benea wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129108/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 10:12 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> added test to check decltype type deduction support in clang
> 
> 
> Diffs
> -----
> 
>   languages/clang/tests/test_duchain.h e4bd5dd 
>   languages/clang/tests/test_duchain.cpp 987b5ee 
> 
> Diff: https://git.reviewboard.kde.org/r/129108/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radu Benea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161006/79077450/attachment.html>