[Differential] [Commented On] D2915: Fix Hide/Restore Docks

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  I agree the current state isn't really good, I've also found some cases where it felt a bit inconsistent.

INLINE COMMENTS

> idealcontroller.cpp:457
>  {
> -    QList<QAction*> allActions;
> -    allActions += leftBarWidget->actions();
> -    allActions += bottomBarWidget->actions();
> -    allActions += rightBarWidget->actions();
> -
> -    bool show = true;
> -    foreach (QAction *action, allActions) {
> -        if (action->isChecked()) {
> -            show = false;
> -            break;
> -        }
> +    bool anyBarShown = leftBarWidget->isShown() || bottomBarWidget->isShown() || rightBarWidget->isShown();
> +

Shouldn't we only save the state when we're hiding?

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2915

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, brauch, #kdevelop
Cc: apol, brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161004/bb621ccf/attachment-0001.html>