[Differential] [Requested Changes To] D2915: Fix Hide/Restore Docks

[brauch (Sven Brauch)]

brauch requested changes to this revision.
brauch added a reviewer: brauch.
brauch added a comment.
This revision now requires changes to proceed.


  Didn't test, but your description fits what the code looks like and I agree that your suggested behaviour is better.
  
  I would suggest to
  
  - move isBarChecked() into a member function if IdealButtonBarWidget and call it isShown or so
  - change the static bools into members of IdealButtonBarWidget, and maybe call it "wasHidden" or something similar
  
  You could easily implement isBarChecked() using std::any_of, but if that really improves readability is up to you.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2915

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161003/cdb51f75/attachment.html>