[Differential] [Accepted] D3551: Fix build system issues

[kfunk (Kevin Funk)]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Feel free to push after fixing those style issues

INLINE COMMENTS

> CMakeLists.txt:67
> +                        SOURCES ${KDEVEMBEDDED_PART_SRCS}
> +                        )
> +kdevplatform_add_plugin(kdevembedded-launcher

Move closing paren to front

> CMakeLists.txt:95
> +configure_file(${CMAKE_CURRENT_SOURCE_DIR}/arduinoversion.h.in
> +            ${CMAKE_CURRENT_BINARY_DIR}/arduinoversion.h)
>  

Style: Indent off

> arduinoversion.h.in:1
> +#ifndef _ARDUINO_VERSION_
> +#define _ARDUINO_VERSION_

Style: Naming scheme is usually like this: `ARDUINOVERSION_H`

REPOSITORY
  R185 KDevelop Plugin: Embedded Platforms

REVISION DETAIL
  https://phabricator.kde.org/D3551

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: obogdan, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel, #kdevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161130/7a76cdcb/attachment-0001.html>