[Differential] [Accepted] D3427: Get more possible types when subscripting.

[brauch (Sven Brauch)]

brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.


  Looks good to me, good feature as well. Thanks once more!

INLINE COMMENTS

> expressionvisitor.cpp:373
> +
> +    if ( auto unsure = lastType().cast<UnsureType>() ) {
> +        FOREACH_FUNCTION ( const auto& type, unsure->types ) {

You could replace this whole if/else by auto valueTypes = Helper::filterType(type, []() { return true; }); if you wanted.

By the way, feel free to replace any QList you find anywhere by QVector ... it's a relict.

REPOSITORY
  rKDEVPYTHON KDev-python

REVISION DETAIL
  https://phabricator.kde.org/D3427

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161120/46a9ff1f/attachment.html>