[Differential] [Request, 19 lines] D3422: Pass AbstractType::Ptr, not Declaration*, to accessAttribute()

[flherne (Francis Herne)]

flherne created this revision.
flherne set the repository for this revision to rKDEVPYTHON KDev-python.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  All but one caller had to look up the declaration only to have it converted back, so the previous version was pointless anyway.
  
  This allows subscripting of expressions (inc. other subscripts), when the subscripted type isn't a ListType/IndexedContainer.
  
  BUG: 359912

TEST PLAN
  No test regressions or new compile warnings.
  
  Fixes both failing examples from https://bugs.kde.org/show_bug.cgi?id=359912 .
  
  TODO: Add tests. Is there a tidier way to add larger chunks of code to tests? I'll ask on IRC.

REPOSITORY
  rKDEVPYTHON KDev-python

REVISION DETAIL
  https://phabricator.kde.org/D3422

AFFECTED FILES
  duchain/declarationbuilder.cpp
  duchain/expressionvisitor.cpp
  duchain/helpers.cpp
  duchain/helpers.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161118/6b839f6f/attachment.html>