[Differential] [Accepted] D3291: Fix problems tooltip

kfunk (Kevin Funk) noreply at phabricator.kde.org
Thu Nov 17 08:25:50 UTC 2016


kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Looks good to me, let's try that in master. We can fix more issues later.

INLINE COMMENTS

> antonanikin wrote in problemnavigationcontext.cpp:85
> Fixed. Thanks for `std::tie` link, but it's impossible to use it for this case - it requires lvalues, but we have only rvalues :(

Ah, sure.

> problemnavigationcontext.cpp:115
>  
> -QString ProblemNavigationContext::html(bool shorten)
> +/// Return HTML-ized text. Used for processing problem's description and explanation.
> +/// Some plugins (kdev-cppcheck for example) return already HTML-ized strings,

Add that documentation snippet to the header file instead.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3291

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, kfunk, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161117/11b71503/attachment.html>


More information about the KDevelop-devel mailing list