[Differential] [Commented On] D2958: Add new action "Focus Editor and Hide Docks"

[antonanikin (Anton Anikin)]

antonanikin added inline comments.

INLINE COMMENTS

> apol wrote in mainwindow_p.cpp:117
> What's the difference between this action and "Hide/Restore Docks"? They feel really similar, too similar.

We have 2 old actions:

1. Focus Editor
2. Hide/Restore Docks.

I don't change them and anything other to keep "old-style" behavior.

The patch adds new action which merges presented 2 "old" parts into simple "chain" for usability improvement. I don't understand what you mean about "too similar" - we have difference in logic for both cases. Maybe you mean that new action is combination of old, but it's wide practice: for example, we have "Copy" (CTRL+C) and "Cut" (CTRL+X) actions in any editor. And it't trivial that "Cut" can be replaced by "Copy"+"Del", but we have separable action for such common operation for usability.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2958

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161104/5ee25e5f/attachment.html>