OOM kills and crashing due to recent changes?

[René J.V. Bertin]

On Friday November 04 2016 15:10:47 René J.V. Bertin wrote:

Hi,

>and then crashed with this partial backtrace:
>
>Thread 1 (Thread 0x7fd9b19a2780 (LWP 12479)):
>[KCrash Handler]
>#6  (anonymous namespace)::addDiagnostics (node=node at entry=0x20d1020, diagnostics=...) at /opt/local/var/lnxports/build/_opt_local_site-ports_kf5_kdevplatform5/kf5-kdevplatform-devel/work/kf5-kdevplatform-5/shell/filteredproblemstore.cpp:39

This can probably be fixed with

diff --git a/shell/filteredproblemstore.cpp b/shell/filteredproblemstore.cpp
index 40962a6..2197392 100644
--- a/shell/filteredproblemstore.cpp
+++ b/shell/filteredproblemstore.cpp
@@ -33,10 +33,12 @@ namespace
 void addDiagnostics(ProblemStoreNode *node, const QVector<IProblem::Ptr> &diagnostics)
 {
     foreach (const IProblem::Ptr &ptr, diagnostics) {
-        ProblemNode *child = new ProblemNode(node, ptr);
-        node->addChild(child);
+        if (ptr.data()) {
+            ProblemNode *child = new ProblemNode(node, ptr);
+            node->addChild(child);
 
-        addDiagnostics(child, ptr->diagnostics());
+            addDiagnostics(child, ptr->diagnostics());
+        }
     }
 }
 


but I just had another kill ("core dump") preceded by a long list of

kdevplatform.language: item index out of bounds: 39 count: 37
kdevplatform.language: item index out of bounds: 983040 count: 37
kdevplatform.language: item index out of bounds: 84142 count: 37
kdevplatform.language: item index out of bounds: 2534992 count: 37

when exiting a session while the background parser was still running (yes, all counts were 37 ... 42 minus the day of the week? B-) ).

R