Review Request 129317: Change automatic SDK installation folder

[patrick pereira]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129317/#review100540
-----------------------------------------------------------


Ship it!




Ship It!

- patrick pereira


On Nov. 3, 2016, 10:31 a.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129317/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 10:31 a.m.)
> 
> 
> Review request for KDevelop and patrick pereira.
> 
> 
> Repository: kdev-embedded
> 
> 
> Description
> -------
> 
> The problem:
> During the automatic SDK installation it was saved to `QStandardPaths::writableLocation(QStandardPaths::DataLocation)`, usually inside *~/.local/share/kdevelop/*, inside a folder called *arduino-*`ARDUINO_SDK_VERSION_NAME` (which is a constraint).
> The problem begins once the plugin get an update and `ARDUINO_SDK_VERSION_NAME` changes (which was already happened, **1.6.9** to **1.6.10**).
> As we are searching for arduino inside *arduino-*`ARDUINO_SDK_VERSION_NAME`, the previously downloaded SDK will not be visible anymore.
> With this path, SDK will be saved to `QStandardPaths::writableLocation(QStandardPaths::DataLocation)`*/arduino* so it won't get lost anymore.
> 
> *Please note, this change does not affect the internal SDK versioning, which is handled in an another place and based on *arduino/revisions.txt* content, not on the folder name*
> 
> 
> Diffs
> -----
> 
>   firsttimewizard.cpp 4a915bf5b7e347bd7e15c94ff44c5361d61a5e4a 
> 
> Diff: https://git.reviewboard.kde.org/r/129317/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161103/64bc37ee/attachment.html>