Review Request 129054: [WIP]Port to KF5/KDevelop5

[Aleix Pol Gonzalez]

> On Sept. 27, 2016, 10:07 p.m., Alexander Zhigalin wrote:
> > browserappjob.cpp, line 79
> > <https://git.reviewboard.kde.org/r/129054/diff/1/?file=481375#file481375line79>
> >
> >     Using execute() KDevelop blocks until the browser is not closed and using start() it doesn't works, maybe because the job is being killed too quickly
> 
> Aleix Pol Gonzalez wrote:
>     You should use `QProcess::start()` indeed.
> 
> Alexander Zhigalin wrote:
>     > You should use QProcess::start() indeed.
>     
>     Have you read what I wrote?
>     > using start() it doesn't works

QProcess::start is used successfully throughout KDE, let alone the greater Qt community. Please debug it instead of discard it.


> On Sept. 27, 2016, 10:07 p.m., Alexander Zhigalin wrote:
> > browserappjob.cpp, line 72
> > <https://git.reviewboard.kde.org/r/129054/diff/1/?file=481375#file481375line72>
> >
> >     By unknown reason it assumes m_url is a local file
> 
> Aleix Pol Gonzalez wrote:
>     Then please make sure the input is sanitized.
> 
> Alexander Zhigalin wrote:
>     The sanitization is the thing which causes the problem
> 
> Alexander Zhigalin wrote:
>     `m_url` is constructed like
>     
>     ```C++
>     url.setScheme("http");
>     url.setHost(host);
>     url.setPath(path);
>     url.setQuery(q);
>     return url;
>     ```
>     
>     But somehow it thoughts `m_url` is a local path and `QUrl::fromUserInput()` is making it work.
>     Maybe is a `QUrl` or `QDesktopServices::openUrl()` bug.
> 
> Aleix Pol Gonzalez wrote:
>     I don't believe that a url with http scheme can be turned into local, there must be something we're missing. Can you maybe make a small test application so we can see what you mean?
> 
> Alexander Zhigalin wrote:
>     > I don't believe that a url with http scheme can be turned into local
>     
>     It just does.
>     Something happens inside `QDesktopServices::openUrl()` and it becomes a local url.
>     But using `QUrl::fromUserInput()` it behaves correctly.
>     
>     P.S. It also behaves correctly if `m_url` is a valid internet URL (no localhost, no 127.0.0.1, no 404 errors) like http://google.com/index.html

That's why I asked for a test case, so we can fix QUrl if necessary.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129054/#review99598
-----------------------------------------------------------


On Nov. 1, 2016, 10:29 p.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129054/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2016, 10:29 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-executebrowser
> 
> 
> Description
> -------
> 
> Port to KF5/KDevelop5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 24ea572d6df7cc3b5fa485e7dff068354e0dfc8c 
>   browserappconfig.h b26c32215dbf15f142aec63fe2ac180bb172c38e 
>   browserappconfig.cpp b7c8a4aed6ed44a069dec57a3e600eeeb8a8ed62 
>   browserappconfig.ui ef205fc6a1edd6cc68e42f5588542a3cd4d764cd 
>   browserappjob.h 37ff7008088706096f73c6da49b46c9234231a0d 
>   browserappjob.cpp a211205aa69b2acc993493b36169c6c1a4cc7b05 
>   cmake/FindKDevPlatform.cmake 1a771c52510cb3e71c19b8a1c84680b6a3c64d08 
>   executebrowserplugin.h 7c787338faeb4fb0749466bb911751c5d72b9093 
>   executebrowserplugin.cpp 95a77aa11ccc97a7625a895032fbb773409cd11e 
>   iexecutebrowserplugin.h f7866227cc8ec0f5946cc78ad35be704ce3aa4f0 
>   kdevexecutebrowser.desktop b5ed913a0f9ed5c4f7b62578f2705560eda48135 
> 
> Diff: https://git.reviewboard.kde.org/r/129054/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161102/852ce587/attachment-0001.html>