Review Request 129054: [WIP]Port to KF5/KDevelop5

[Aleix Pol Gonzalez]

> On Sept. 27, 2016, 11:07 p.m., Kevin Funk wrote:
> > Looks good to me in general.
> 
> Alexander Zhigalin wrote:
>     Ping
> 
> Kevin Funk wrote:
>     Hmm? The patch still has lots of the issues open (e.g. the `cmake_minimum_required(...)` issue)
> 
> Alexander Zhigalin wrote:
>     I know, but I do not know how to solve these issues. 
>     (e.g. I don't know which cmake version is needed)
> 
> Alexander Zhigalin wrote:
>     Another ping.
>     Please help me!

In most KDE projects we have `cmake_minimum_required(VERSION 2.8.12)`.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129054/#review99600
-----------------------------------------------------------


On Sept. 30, 2016, 12:33 a.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129054/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 12:33 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-executebrowser
> 
> 
> Description
> -------
> 
> Port to KF5/KDevelop5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 24ea572d6df7cc3b5fa485e7dff068354e0dfc8c 
>   browserappconfig.h b26c32215dbf15f142aec63fe2ac180bb172c38e 
>   browserappconfig.cpp b7c8a4aed6ed44a069dec57a3e600eeeb8a8ed62 
>   browserappconfig.ui ef205fc6a1edd6cc68e42f5588542a3cd4d764cd 
>   browserappjob.h 37ff7008088706096f73c6da49b46c9234231a0d 
>   browserappjob.cpp a211205aa69b2acc993493b36169c6c1a4cc7b05 
>   cmake/FindKDevPlatform.cmake 1a771c52510cb3e71c19b8a1c84680b6a3c64d08 
>   executebrowserplugin.h 7c787338faeb4fb0749466bb911751c5d72b9093 
>   executebrowserplugin.cpp 95a77aa11ccc97a7625a895032fbb773409cd11e 
>   iexecutebrowserplugin.h f7866227cc8ec0f5946cc78ad35be704ce3aa4f0 
>   kdevexecutebrowser.desktop b5ed913a0f9ed5c4f7b62578f2705560eda48135 
> 
> Diff: https://git.reviewboard.kde.org/r/129054/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161101/981c8265/attachment.html>