[Differential] [Commented On] D1693: KDevelop LLDB support - GDB plugin refactor

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  In https://phabricator.kde.org/D1693#31430, @qi437103 wrote:
  
  > I rethought about the KDevDebugger namespace. It's maybe better to not change, as I'd consider it as an umbrella namespace for all debuggers in KDevelop. The MI prefix in class names is sufficient to say they are only for MI protocol based debuggers.
  >
  > Also, it's kind of confusing to have the namespace using the same name as a class inside it.
  >
  > So I suggest the following renaming in addition
  >
  > - KDevDebugger::GDB::GDB -> KDevDebugger::GDB::GdbDebugger
  > - KDevDebugger::BreakpointControllerBase -> KDevDebugger::MIBreakpointController
  > - KDevDebugger::VariableControllerBase -> KDevDebugger::MIVariableController
  
  
  It doesn't make sense to share a namespace between modules that will not share code. In fact, this namespace is probably unnecessary altogether, since it's just used to outline the implementation detail.
  
  As for the other plugins, you can find them here: https://quickgit.kde.org/, look at those starting with `kdev-*` i.e. crossfire, xdebug. I don't know if there's more. scummos would know if there's something for python within kdev-python.
  
  HTH

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D1693

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: qi437103, apol
Cc: kdevelop-devel