Review Request 128016: [OS X] Prevent a crash in the IdealDockWidget's context menu

[René J.V. Bertin]

> On May 26, 2016, 10:56 a.m., Sven Brauch wrote:
> > sublime/idealdockwidget.cpp, line 119
> > <https://git.reviewboard.kde.org/r/128016/diff/1/?file=465464#file465464line119>
> >
> >     ... and, by the way, this should have the menu as parent, right? using this will leak it
> 
> René J.V. Bertin wrote:
>     That's independent of my patch, no?
> 
> Sven Brauch wrote:
>     Yes :) but while you're touching it ...

While I was at it ... I've preferred to use a QScopedPointer here too, preventing just the leak and not touching any parenting relationships :)


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128016/#review95813
-----------------------------------------------------------


On May 26, 2016, 1:21 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128016/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 1:21 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> OS X can be capricious when instances corresponding to a widget are deleted, if the class in question uses "native" ObjC SDKs behind the scenes. Pending events can in that case be (generated and) delivered to objects that were already deleted.
> According to the documentation, one should prefer to use `QObject::deleteLater()` rather than the regular, direct `delete` whether it be explicit or implicit.
> 
> I've long used a local patch that uses this approach in order to prevent a recurring crash after using the context menu of the "ideal dock widget". Somehow I never put it up for review here, apparently.
> 
> 
> Diffs
> -----
> 
>   sublime/idealdockwidget.cpp dae0ea2 
> 
> Diff: https://git.reviewboard.kde.org/r/128016/diff/
> 
> 
> Testing
> -------
> 
> Builds and permits reliable behaviour on both OS X and Linux.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160526/b3f8aec9/attachment.html>