Review Request 128012: Check for an existing out-of-source build dir

[René J.V. Bertin]

> On May 25, 2016, 6 p.m., Aleix Pol Gonzalez wrote:
> > So what's your use-case?
> > 
> > Do you want to have `projects/dolphin` and `projects/build`?

My use case is indeed one in which I have a work directory that holds separate source, build and possibly other directories (a temporary install directory, for instance).

If I thought out-of-source build directories were that uncommon I wouldn't have proposed this patch of course. But your example is why I added a suggestion to check only for pre-configured o-o-s build directories.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128012/#review95781
-----------------------------------------------------------


On May 25, 2016, 4:48 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128012/
> -----------------------------------------------------------
> 
> (Updated May 25, 2016, 4:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> When importing a new project, check if it already has a pre-existing out-of-source build directory, and propose that as the build directory in `KDevelop::proposedBuildFolder()`.
> This is comparable to proposing to put the build folder alongside an existing `src` directory (but has priority over that rule).
> 
> 
> Diffs
> -----
> 
>   project/helper.cpp 6df9f90 
> 
> Diff: https://git.reviewboard.kde.org/r/128012/diff/
> 
> 
> Testing
> -------
> 
> Builds and behaves as expected.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160525/73c0035e/attachment.html>