Review Request 127885: Implement color scheme selection from these installed in the system

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127885/#review95759
-----------------------------------------------------------



I agree that, if possible, we should use the color manager proposed by Kai Uwe. If there's anything missing from that API, we can add it there.

And Alexander: This is great work! This patch clearly shows that you are not afraid of touching C++ code, so if you managed to patch KDevelop I'm sure you are capable of patching the frameworks API for the color manager as needed. If you have any question, don't hesitate to ask again.

Cheers, hope to see this go forward!


shell/mainwindow.h (line 91)
<https://git.reviewboard.kde.org/r/127885/#comment64805>

    Please take the QString by const&, i.e. write:
    
        void saveCurrentTheme(const QString& name);
    
    and update the implementation signature in the .cpp accordingly. This is a (minor) performance improvement and also follows the Qt coding style.


- Milian Wolff


On May 10, 2016, 1:11 p.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127885/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 1:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 279592
>     http://bugs.kde.org/show_bug.cgi?id=279592
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Implement color scheme selection from these installed in the system.
> Ported from The Digikam Project.
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 752c435b81d60e6bf9d438a0367662a8be346a33 
>   shell/mainwindow.h 8340064ee7e1a3b95695b430270cc848ac69eeac 
>   shell/mainwindow.cpp cf1b15d99365a1274f49bbde18bf3c5c17ba7ccb 
>   shell/mainwindow_p.cpp 70b56db7bed09aeea7a0e57307fb870f65471574 
>   shell/schememanager.h PRE-CREATION 
>   shell/schememanager.cpp PRE-CREATION 
>   shell/thememanager.h PRE-CREATION 
>   shell/thememanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127885/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Color scheme for KTextEditor to use with dark color schemes
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/10/88f4ff18-aa10-426c-85ea-4d4d05c04609__Breeze_Dark.kateschema
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160524/7706c662/attachment.html>