[Differential] [Commented On] D1674: kdev-embedded review

[patrickelectric (patrick j pereira)]

patrickelectric added inline comments.

INLINE COMMENTS

> arduinowindow.cpp:368
> +    if (list.size() <= 1)
> +        item = "<font color='red'>"+list[0]+"</font>";
> +    else

<kfunk> : small note: use KColorScheme in ArduinoWindow::getRedRichTextSelected, instead of a hard-coded 'red'
e.g. KColorScheme(KColorScheme::View, KColorScheme::NegativeText)
 or sth else as 2nd param -- I don't think it's supposed to be 'negative'

> arduinowindow.h:11
> +#include <QProcess>
> +/*
> +namespace QProcess

lost comment

REPOSITORY
  rKDEVEMBEDDED KDevelop Plugin: Embedded Platforms

REVISION DETAIL
  https://phabricator.kde.org/D1674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: patrickelectric, brauch, tcanabrava
Cc: tcanabrava, patrickelectric, brauch, kdevelop-devel