Review Request 127979: [WIP] Implement color scheme selection from these installed in the system using KColorSchemeManager

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127979/#review95679
-----------------------------------------------------------




shell/thememanager.h (line 37)
<https://git.reviewboard.kde.org/r/127979/#comment64788>

    Maybe it should be called `ColorSchemeManager`? I'd also change other `Theme` uses for `ColorScheme`.



shell/thememanager.h (line 65)
<https://git.reviewboard.kde.org/r/127979/#comment64785>

    `const QString &name`



shell/thememanager.cpp (line 55)
<https://git.reviewboard.kde.org/r/127979/#comment64786>

    Why isn't it a `Q_GLOBAL_STATIC(ThemeManager, object)`? Also usually static members have a `s_` prefix. I suggest: `s_themeManager`.



shell/thememanager.cpp (line 106)
<https://git.reviewboard.kde.org/r/127979/#comment64787>

    Capitalization: `currentDesktopDefaultTheme()`



shell/thememanager.cpp (line 133)
<https://git.reviewboard.kde.org/r/127979/#comment64784>

    Instead of setWindow, we could be returning its own KActionCollection, this way we don't have to track 3rd objects.



shell/thememanager.cpp (line 137)
<https://git.reviewboard.kde.org/r/127979/#comment64782>

    The only reason we are passing the QApplication is so that `d->manager` has a parent?
    
    I'd rather manage it within ThemeManager by using QScopedPointer or such. `d->manager` can be initialized the first time it's used. Or `this`.



shell/thememanager.cpp (line 155)
<https://git.reviewboard.kde.org/r/127979/#comment64783>

    Again QScopedPointer.


- Aleix Pol Gonzalez


On May 20, 2016, 9:44 p.m., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127979/
> -----------------------------------------------------------
> 
> (Updated May 20, 2016, 9:44 p.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Bugs: 279592
>     http://bugs.kde.org/show_bug.cgi?id=279592
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> [WIP] Implement color scheme selection from these installed in the system using KColorSchemeManager
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ec521ab8f5dcdd1cc175809f56169259e241ea34 
>   shell/CMakeLists.txt 752c435b81d60e6bf9d438a0367662a8be346a33 
>   shell/mainwindow.h 8340064ee7e1a3b95695b430270cc848ac69eeac 
>   shell/mainwindow.cpp cf1b15d99365a1274f49bbde18bf3c5c17ba7ccb 
>   shell/mainwindow_p.cpp 70b56db7bed09aeea7a0e57307fb870f65471574 
>   shell/thememanager.h PRE-CREATION 
>   shell/thememanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127979/diff/
> 
> 
> Testing
> -------
> 
> Not tested yet
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160521/7f6ceae5/attachment.html>