[Differential] [Changed Subscribers] D1634: Fix imports for several built-in QML modules

[apol (Aleix Pol Gonzalez)]

apol added inline comments.

INLINE COMMENTS

> cache.cpp:84
>  
> -    if (!version.isEmpty() && !isVersion1) {
> +    QStringList modulesWithoutVersionSuffix =
> +        QStringList()

Make const? maybe use the list initializer?

> cache.cpp:107
>              }
>          } else if (QFile::exists(pathString)) {
> +            QStringList nameFilter("*.qmltypes");

Looks to me that it's always called `plugins.qmltypes`. It would be much faster if we can keep it to just a `QFile::exists(pathString+"/plugins.qmltypes")`

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D1634

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cordlandwehr, KDevelop, brauch, kfunk
Cc: apol, kdevelop-devel