[Differential] [Accepted] D1554: Add GUI feedback if no system QtHelp file is available

apol (Aleix Pol Gonzalez) noreply at phabricator.kde.org
Wed May 11 00:55:19 UTC 2016


apol accepted this revision.
apol added a reviewer: apol.
apol added a comment.


  Looks good to me all in all. Maybe a unit test could be introduced. That would be very welcome.
  
  For now, let's get this in (modulo the nitpicks).

INLINE COMMENTS
  documentation/qthelp/qthelpconfig.cpp:391 Maybe "Qt API Documentation"?
  documentation/qthelp/qthelpplugin.cpp:165 name isQtHelpAvailable (bool property naming convention).
  documentation/qthelp/qthelpqtdoc.cpp:124 Use entryInfoList so you don't need to explicitly construct the path.

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D1554

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cordlandwehr, kfunk, KDevelop, apol
Cc: apol, kfunk, kdevelop-devel, Pilzschaf, akshaydeo, patrickelectric, surgenight, joshiakshay, arrowdodger


More information about the KDevelop-devel mailing list