Review Request 127885: Implement color scheme selection from these installed in the system
Kevin Funk
kfunk at kde.org
Tue May 10 10:38:06 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127885/#review95328
-----------------------------------------------------------
Rest LGTM, but I didn't try it out yet.
shell/CMakeLists.txt (line 56)
<https://git.reviewboard.kde.org/r/127885/#comment64647>
Remove empty newlines
shell/mainwindow.h (line 91)
<https://git.reviewboard.kde.org/r/127885/#comment64646>
`const QString&`
- Kevin Funk
On May 10, 2016, 10:20 a.m., Alexander Zhigalin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127885/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 10:20 a.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> Implement color scheme selection from these installed in the system.
> Ported from The Digikam Project.
>
>
> Diffs
> -----
>
> shell/CMakeLists.txt 752c435b81d60e6bf9d438a0367662a8be346a33
> shell/mainwindow.h 8340064ee7e1a3b95695b430270cc848ac69eeac
> shell/mainwindow.cpp cf1b15d99365a1274f49bbde18bf3c5c17ba7ccb
> shell/mainwindow_p.cpp 70b56db7bed09aeea7a0e57307fb870f65471574
> shell/schememanager.h PRE-CREATION
> shell/schememanager.cpp PRE-CREATION
> shell/thememanager.h PRE-CREATION
> shell/thememanager.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/127885/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Zhigalin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160510/a5c35c61/attachment.html>
More information about the KDevelop-devel
mailing list