Review Request 127827: open/fetch project: restore broken workflows after native file dialog port
Sven Brauch
mail at svenbrauch.de
Tue May 3 22:22:38 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127827/
-----------------------------------------------------------
Review request for KDevelop and Kevin Funk.
Repository: kdevplatform
Description
-------
The native dialog has two significant restrictions: it cannot be embedded, and it cannot be told to accept both a directory _or_ a file at once. The previous change to the open project dialog broke the (important) option to open a directory as a project. This fixes that through introduction of an extra step: you select the method you want to open your project with first. This has the advantage of making it more clear to the user what the options are; many users are still not aware you can simply tell KDevelop to open a folder as a project.
I'm well aware this is far from an optimal solution, but right now it's just broken and this is certainly an improvement over the current situation. Better ideas welcome.
Diffs
-----
shell/CMakeLists.txt 83d4db0
shell/openprojectdialog.h d39ff8e
shell/openprojectdialog.cpp 9ccca43
shell/openprojectdialog.ui PRE-CREATION
shell/projectsourcepage.h a45ee19
shell/projectsourcepage.cpp 43ab6e9
shell/projectsourcepage.ui 79699aa
Diff: https://git.reviewboard.kde.org/r/127827/diff/
Testing
-------
can open from CMakeLists.txt, from foo.kdev5 or from a folder; also fetch works again (before simply random stuff happened)
File Attachments
----------------
the added dialog
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/03/7b6cdfc2-c4d7-4394-9a39-2ccc923f28fa__Screenshot_20160504_001810.png
Thanks,
Sven Brauch
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160503/c6e797f0/attachment.html>
More information about the KDevelop-devel
mailing list