[Differential] [Request, 73 lines] D1523: Project Manager View plugin has hardcoded/fixed shortcuts

[rjvbb (René J.V. Bertin)]

rjvbb created this revision.
rjvbb added a subscriber: KDevelop.
rjvbb set the repository for this revision to rKDEVPLATFORM KDevPlatform.
rjvbb added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  From https://bugs.kde.org/show_bug.cgi?id=362545 :
  
  The Project Manager View plugin hardcodes a number of shortcuts, among others for item removal, renaming, copy and paste. The remove, copy and paste shortcuts are standard and probably unlikely to be redefined, but the rename action is made available via the F2 key. I use that shortcut in KWin4 (for lowering the focus window), and it turns out that the keystroke is not eaten by KWin but passed on to the next window that receives focus, or when KDevelop itself is being lowered this way.
  
  I've tried to make a start towards replacing these fixed shortcuts with user-modifiable ones. The QAction shortcuts work as expected, but I haven't yet been able to figure out how to make them appear in the shortcut settings dialog. Draft patch attached.
  
  Reproducible: Always
  
  Steps to Reproduce:
  
  1. Map F2 to "lower window"
  2. Select a Focus-Really-Follows-Mouse focussing model
  3. Open a project in KDevelop5
  4. Select an item in the project manager
  5. Put a window in front of KDevelop and lower it via F2 or lower KDevelop itself via F2
  
  Actual Results:  
  A Rename dialog pops up; one cannot change or undefine the shortcut
  
  Expected Results:  
  It should be possible to change or remove the shortcut
  
  The undesirable described effect above happens for me on a KDE4/Plasma desktop but should occur in all situations where one of the shortcuts is mapped globally to a different action.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D1523

AFFECTED FILES
  plugins/projectmanagerview/projectmanagerview.cpp
  plugins/projectmanagerview/projectmanagerviewplugin.cpp
  plugins/projectmanagerview/projectmanagerviewplugin.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rjvbb
Cc: kdevelop-devel, KDevelop, patrickelectric, surgenight, arrowdodger