[Differential] [Request, 12 lines] D1266: Misleading indentation fixes (GCC6)
egorov (Boris Egorov)
noreply at phabricator.kde.org
Wed Mar 30 15:23:13 UTC 2016
egorov created this revision.
egorov added a reviewer: KDevelop.
egorov set the repository for this revision to rKDEVELOP KDevelop.
egorov added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
REVISION SUMMARY
These all look innocent enough, but why not to fix them.
Some analysis:
qmljsinterpreter.cpp: Just wrong indentation
makefileresolver.cpp workingDirectory: Looks like this path is never
executed (we call this function only with absolute path)
makefileresolver.cpp res.paths: This one is probably a real issue - it uses
cachedDefines every time instead of only when res.paths.isEmpty().
REPOSITORY
rKDEVELOP KDevelop
REVISION DETAIL
https://phabricator.kde.org/D1266
AFFECTED FILES
languages/qmljs/libs/qmljs/qmljsinterpreter.cpp
projectmanagers/custommake/makefileresolver/makefileresolver.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: egorov, KDevelop
Cc: kdevelop-devel, surgenight, arrowdodger
More information about the KDevelop-devel
mailing list