Review Request 124934: Fix declaration tooltip flickering

Maciej Cencora m.cencora at gmail.com
Mon Mar 21 11:22:22 UTC 2016



> On Wrz 27, 2015, 7:35 po południu, Milian Wolff wrote:
> > has this been committed? Not as far as I can see. But the latest patch does not contain all required changes, or?
> 
> Maciej Cencora wrote:
>     Once I add a test I think it can be pushed. FYI I'm working on a follow-up patch that fixes flickering for tooltips in debuging view.
> 
> Kevin Funk wrote:
>     Bump. @Maciej: What's up with this patch?

This can be discarded, since the flicker fix part of this was committed in 8b3f3e394b (review 125447) and the DUContext related part was fixed by someone else in the meantime (most probably in the Clang plugin).


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124934/#review86021
-----------------------------------------------------------


On Sie 27, 2015, 1:08 po południu, Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124934/
> -----------------------------------------------------------
> 
> (Updated Sie 27, 2015, 1:08 po południu)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Actually make use of ActiveToolTip::addExtendedRect (renamed to setHandleRect).
> This functionality was lost with d77a4ecda51c324eec589167da3214d21a1eff42
> 
> Minor change was also needed in itemRangeUnderCursor:
> DUContext::findContextAt for cursor at function name returns the function's context, searching for function's name inside it will fail - we need to search in parent context.
> 
> 
> Diffs
> -----
> 
>   language/duchain/duchainutils.cpp a1ff0f5 
>   util/activetooltip.cpp e45116c 
> 
> Diff: https://git.reviewboard.kde.org/r/124934/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160321/5020e990/attachment.html>


More information about the KDevelop-devel mailing list