[Differential] [Accepted] D1145: DUChain: Prioritize active documents

[mwolff (Milian Wolff)]

mwolff accepted this revision.
mwolff added a reviewer: mwolff.
mwolff added a comment.
This revision is now accepted and ready to land.


  cool, thanks for this! small nitpicks, otherwise good to go.
  
  one question though: when we startup kdevelop with ~20 documents open, are they activated one after the other, leading to ~20 high priority parse jobs? that would need to be work-arounded via a timer then I think... If this is the case (and I actually fear that's the case), then I'd leave the function you touched as-is and only change the background parser to increase priority of activated documents after some time
  
  could we get a unit test for this as well? would be nice to have I think, but not too important

INLINE COMMENTS
  language/duchain/duchain.cpp:1467 just "update", remove dash
  language/duchain/duchain.cpp:1468 you could just write a bool flag here, i.e.
  
  addWithHighPriority = true;
  
  and then...
  language/duchain/duchain.cpp:1476 check for `addWithHighPriority || ...` here, as the call to addDocument is equal in both cases, no?

REPOSITORY
  rKDEVPLATFORM KDevPlatform

BRANCH
  assistantpopup-ng

REVISION DETAIL
  https://phabricator.kde.org/D1145

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, mwolff
Cc: mwolff, kdevelop-devel, arrowdodger